Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeekscript: add build dependencies and fix metadata #246908

Merged
merged 1 commit into from
Aug 3, 2023
Merged

zeekscript: add build dependencies and fix metadata #246908

merged 1 commit into from
Aug 3, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

Extracted from #245509. When we use build to build packages instead of pip, we need to add wheel explicitly to the build dependencies, and pyproject.toml needs to have a version field.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Aug 3, 2023

Result of nixpkgs-review pr 246908 run on x86_64-linux 1

2 packages built:
  • zeekscript
  • zeekscript.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 4b07171 into NixOS:master Aug 3, 2023
@tjni tjni deleted the zeekscript branch August 3, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants