Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.oldest-supported-numpy: init at 2023.8.3 #247073

Merged
merged 1 commit into from
Aug 7, 2023
Merged

python3.pkgs.oldest-supported-numpy: init at 2023.8.3 #247073

merged 1 commit into from
Aug 7, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 4, 2023

Description of changes

The main purpose of this package is to be used as a dependency in projects that depend upon it without having to patch their build dependency requirements.

In my opinion, adding this dependency is easier to follow, review, and understand than patching a pyproject.toml file. Feedback and other opinions welcome for discussion.

Related to #245509.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The main purpose of this package is to be used as a dependency in
projects that depend upon it without having to patch their build
dependency requirements.
@FRidh
Copy link
Member

FRidh commented Aug 7, 2023

So far we have only few occurrences but I image this package to be used more in the future.

@FRidh FRidh merged commit 3dfe8ff into NixOS:master Aug 7, 2023
@tjni tjni deleted the oldest-supported-numpy branch August 7, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants