Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.astroid: add wheel and pip dependencies #247258

Merged
merged 1 commit into from
Aug 12, 2023
Merged

python3.pkgs.astroid: add wheel and pip dependencies #247258

merged 1 commit into from
Aug 12, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

This will be needed by (and is extracted from) #245509 for ease of reviewing. This PR adds two dependencies to astroid that were implicitly provided by Python setup hooks but will no longer be.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni changed the base branch from master to staging August 5, 2023 03:07
@tjni tjni marked this pull request as ready for review August 5, 2023 03:07
@tjni
Copy link
Contributor Author

tjni commented Aug 5, 2023

@ofborg eval

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 9, 2023
@FRidh FRidh merged commit f06e634 into NixOS:staging Aug 12, 2023
@tjni tjni deleted the astroid branch August 12, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants