Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.datrie: add build dependencies and improve derivation #247306

Merged
merged 1 commit into from
Aug 11, 2023
Merged

python3.pkgs.datrie: add build dependencies and improve derivation #247306

merged 1 commit into from
Aug 11, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 5, 2023

Description of changes

  1. Add an explicit wheel dependency, as I think that will be needed one day.
  2. Fetch patch that removes unnecessary build-time dependency on pytest-runner.
  3. Move hypothesis into nativeCheckInputs (I'm not sure what checkInputs adds if anything).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, and thanks for contrib!

pkgs/development/python-modules/datrie/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from nlewo August 10, 2023 04:46
@FRidh FRidh merged commit 2d6cf36 into NixOS:master Aug 11, 2023
@tjni tjni deleted the datrie branch August 11, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants