nixos/nixosSystem: Remove deprecated arguments, deprecate pkgs argument, and add errors to specialArgs #247448
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
github-actions
bot
added
the
8.has: module (update)
|
TODO: add documentation |
There was a problem hiding this comment.
- A bit too aggressive on the stable api.
- Secondarily: don't tolerate error conditions with just a warning.
Also seems like a good idea to finish #231940 before triggering deployment tool maintainers to look at their nixpkgs.* situation.
| ++ | ||
| (optional (pkgs_ != null) { | ||
| _module.args.pkgs = lib.mkForce pkgs_; | ||
| }) |
There was a problem hiding this comment.
We shouldn't change the behavior with just a warning, and I feel like this is too big a change anyway - as this is the stable NixOS entrypoint.
How about we start with removing pkgs from lib.nixosSystem? That's a weird one, where it's unclear what the intent should even be: ignore nixpkgs.*? Use readOnlyPkgs? I think both are equally surprising and users should make a choice (if they pass pkgs at all).
There was a problem hiding this comment.
Yeah that should either be changed to a error or added back
I think specialArgs should at least have a warning saying it can potentially be harmful
|
I mostly agree with you roberth Mainly put this out there to get opinions This should definitely merge after #231940 |
github-actions
bot
removed
the
8.has: module (update)
Gerg-L
changed the title
pkgs to specialArgs and lib.nixosSystem
|
i'll make a similar PR later |
Description of changes
passing
pkgstospecialArgsandlib.nixosSystemis a common anti-pattern that new users fall into which causes unexpected behavior and complete ignorance to thenixpkgs.option setSince readOnlyPkgs has merged there's a easy immutable way to set
pkgsI think it's time to do away with alternative handling methods of
pkgsopinions are appreciated, thanks