Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.pydeck: 0.7.1 -> 0.8.0 #247508

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

natsukium
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 247508 run on x86_64-linux 1

2 packages failed to build:
  • streamlit
  • streamlit.dist
4 packages built:
  • python310Packages.pydeck
  • python310Packages.pydeck.dist
  • python311Packages.pydeck
  • python311Packages.pydeck.dist

@natsukium
Copy link
Member Author

streamlit will be fixed in #242594.

@natsukium natsukium marked this pull request as draft August 6, 2023 14:19
@natsukium natsukium marked this pull request as ready for review August 6, 2023 16:17
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 27 to 31
nativeBuildInputs = [
setuptools
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're here, would you mind also adding wheel? It's implicitly added by Python setup hooks at the moment, but I'm hoping that will change with some work I'm doing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it.

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 9, 2023
@FRidh FRidh merged commit 32c8912 into NixOS:master Aug 11, 2023
@natsukium natsukium deleted the pydeck/update branch August 11, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants