Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.setuptools-git-versioning: init at 1.13.5 #248019

Merged
merged 1 commit into from
Aug 10, 2023
Merged

python3.pkgs.setuptools-git-versioning: init at 1.13.5 #248019

merged 1 commit into from
Aug 10, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 8, 2023

Description of changes

This is used by several projects as a build-time dependency, and I would like to package it to give us options about how we should handle those cases. I did see dolfinus/setuptools-git-versioning#77, and I'm not sure what the best way is yet.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 8, 2023
@natsukium
Copy link
Member

@ofborg build python310Packages.setuptools-git-versioning

@natsukium
Copy link
Member

Result of nixpkgs-review pr 248019 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.setuptools-git-versioning
  • python311Packages.setuptools-git-versioning.dist
2 packages built:
  • python310Packages.setuptools-git-versioning
  • python310Packages.setuptools-git-versioning.dist

@natsukium
Copy link
Member

error: builder for '/nix/store/kwriig3zcm1jq3x4qkfx2dg20yblzkk8-python3.11-setuptools-git-versioning-1.13.5.drv' failed with exit code 4;
       last 10 log lines:
       > Check whether the following modules can be imported: setuptools_git_versioning
       > pytestCheckPhase
       > Executing pytestCheckPhase
       > ImportError while loading conftest '/build/source/tests/conftest.py'.
       > tests/conftest.py:7: in <module>
       >     from tests.lib.util import create_file, execute, rand_str
       > tests/lib/util.py:13: in <module>
       >     import toml
       > E   ModuleNotFoundError: No module named 'toml'

@tjni
Copy link
Contributor Author

tjni commented Aug 10, 2023

Good catch, I didn't test it on Python 3.11. I can fix this upstream.

@tjni
Copy link
Contributor Author

tjni commented Aug 10, 2023

Oh, it uses toml in tests to write, which is not in the Python 3.11 standard library. So we've got to add the dependency in our derivation. I will get to it sometime soon. I'm building the whole bootstrap right now from staging.

@natsukium
Copy link
Member

I'm building the whole bootstrap right now from staging.

Sounds like hard work. 😵

@tjni
Copy link
Contributor Author

tjni commented Aug 10, 2023

Sounds like hard work. 😵

For my computer 🥲

@tjni
Copy link
Contributor Author

tjni commented Aug 10, 2023

I verified that the tests pass on Python 3.11 now after adding toml to nativeCheckInputs. Let's kick it off again:

@ofborg build python310Packages.setuptools-git-versioning python311Packages.setuptools-git-versioning

@natsukium
Copy link
Member

Result of nixpkgs-review pr 248019 run on x86_64-linux 1

4 packages built:
  • python310Packages.setuptools-git-versioning
  • python310Packages.setuptools-git-versioning.dist
  • python311Packages.setuptools-git-versioning
  • python311Packages.setuptools-git-versioning.dist

@natsukium natsukium merged commit b8392f9 into NixOS:master Aug 10, 2023
@tjni tjni deleted the setuptools-git-versioning branch August 10, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants