-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3.pkgs.setuptools-git-versioning: init at 1.13.5 #248019
Conversation
@ofborg build python310Packages.setuptools-git-versioning |
Result of 2 packages failed to build:
2 packages built:
|
|
Good catch, I didn't test it on Python 3.11. I can fix this upstream. |
Oh, it uses |
Sounds like hard work. 😵 |
For my computer 🥲 |
I verified that the tests pass on Python 3.11 now after adding @ofborg build python310Packages.setuptools-git-versioning python311Packages.setuptools-git-versioning |
Result of 4 packages built:
|
Description of changes
This is used by several projects as a build-time dependency, and I would like to package it to give us options about how we should handle those cases. I did see dolfinus/setuptools-git-versioning#77, and I'm not sure what the best way is yet.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)