Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.xknx: fix up build dependencies #248067

Merged
merged 1 commit into from
Aug 10, 2023
Merged

python3.pkgs.xknx: fix up build dependencies #248067

merged 1 commit into from
Aug 10, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 9, 2023

Description of changes

  1. Pull in a patch upstream that unpins setuptools.
  2. Add wheel to nativeBuildInputs. This is implicit right now but I am working on making it explicit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 9, 2023
Closed
@ofborg ofborg bot requested a review from fabaff August 9, 2023 03:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 9, 2023
@natsukium
Copy link
Member

@ofborg build python310Packages.xknx

@natsukium
Copy link
Member

Result of nixpkgs-review pr 248067 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.knx
  • python310Packages.xknx
  • python310Packages.xknx.dist
  • python311Packages.xknx
  • python311Packages.xknx.dist

natsukium
natsukium approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit e730661 into NixOS:master Aug 10, 2023
@tjni tjni deleted the xknx branch August 10, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjni @natsukium