Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.orjson: 3.9.2 -> 3.9.4 #248273

Merged
merged 1 commit into from
Aug 11, 2023
Merged

python3.pkgs.orjson: 3.9.2 -> 3.9.4 #248273

merged 1 commit into from
Aug 11, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 10, 2023

Description of changes

https://github.com/ijl/orjson/blob/master/CHANGELOG.md#394---2023-08-07

I am especially interested in ijl/orjson@f94318a, which has the following change:

< MAX_INCREASE = 1048576 # 1MiB
> MAX_INCREASE = 2097152 # 2MiB

This increases the amount that one of the tests allows RSS to grow. I have been frequently seeing this test fail time to time, especially when my system is under load building other packages. This ends up costing me a lot of time, because it usually aborts other expensive builds (e.g. other versions of LLVM, gfortran, etc.) that I have running at the same time.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 03ef702 into NixOS:staging Aug 11, 2023
@tjni tjni deleted the orjson branch August 11, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants