Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beautysh: patch "poetry" reference in pyproject.toml #248598

Merged
merged 1 commit into from
Aug 14, 2023
Merged

beautysh: patch "poetry" reference in pyproject.toml #248598

merged 1 commit into from
Aug 14, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 11, 2023

Description of changes

Pull in lovesegfault/beautysh#247, which I submitted upstream. The build-backend path was already correct, but the leftover reference to "poetry" instead of "poetry-core" fails the build when build is used.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Aug 12, 2023

Result of nixpkgs-review pr 248598 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.mdformat-beautysh
  • python311Packages.mdformat-beautysh.dist
4 packages built:
  • beautysh
  • beautysh.dist
  • python310Packages.mdformat-beautysh
  • python310Packages.mdformat-beautysh.dist

@fabaff
Copy link
Member

fabaff commented Aug 12, 2023

mdformat-beautysh failure will be fixed with #248677.

@FRidh FRidh merged commit 3b7deba into NixOS:master Aug 14, 2023
@tjni tjni deleted the beautysh branch August 14, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants