brotab: patch out unnecessary "import pip" in setup.py

[tjni]

Description of changes

In some work I'm doing changing the Python bootstrap, pip is no longer part of the environment by default. This revealed that the setup.py of this project has an "import pip" that is no longer being used.

This is a one line change that could be done with a sed command, but I prefer pulling in the patch I submitted upstream as a signal that this is an upstream problem that should be fixed versus a nixpkgs specific patch.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[doronbehar]

Hey! Noticed your work on the Python ecosystem and it is really appreciated! Question: Why do you add the __darwinAllowLocalNetworking attribute to these PRs?

[tjni]

Hi! Thank you!

The __darwinAllowLocalNetworking attribute is actually a special one that tells nix to add some values to the Apple sandbox so that it's possible to connect to localhost when running a derivation on macOS with sandbox enabled. I've been running with the sandbox on, so I add these when I can so that tests pass locally for me. Hope this makes sense :)

[doronbehar]

It makes sense, I'm just wondering why no Darwin user has ever noticed that this is needed, for the scipy package for example, which is much more common than this.

[tjni]

I'm honestly not sure. I do know that the sandbox is turned off by default on Darwin and is also off on Hydra, so that might be one of the reasons. Also, if someone only uses a stable channel, they might always be able to get it from the binary cache.

[doronbehar]

Result of nixpkgs-review pr 248601 run on x86_64-linux 1

2 packages built:

• brotab
• brotab.dist