Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.statsmodels: add build dependencies and fix constraints #248759

Merged
merged 1 commit into from
Aug 18, 2023
Merged

python3.pkgs.statsmodels: add build dependencies and fix constraints #248759

merged 1 commit into from
Aug 18, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 12, 2023

Description of changes

Adds some missing explicit build dependencies and pulls in a patch to unpin setuptools-scm. This will be needed prior to switching the Python builds to using build. The build works fine today without these because:

  1. wheel is pulled in implicitly by Python build hooks
  2. oldest-supported-numpy is strictly used only for dependency validation

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 17, 2023

@ofborg build python3.pkgs.statsmodels

@tjni tjni merged commit 38527fa into NixOS:master Aug 18, 2023
@tjni tjni deleted the statsmodels branch August 18, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant