Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openrazer-daemon: do not install twice #248800

Merged
merged 1 commit into from
Aug 17, 2023
Merged

openrazer-daemon: do not install twice #248800

merged 1 commit into from
Aug 17, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

While working on switching the Python package installer from pip to installer, discovered that this package was installing the same files twice. Its postBuild phase runs "make install", which calls "setup.py install". Then, in installPhase, pip is used to install again. This begins to break with installer, which notices that files it is writing to already exist. This PR fixes that by only calling the Makefile targets that do not install the Python wheel. In addition:

  1. Add format = "setuptools" as best practice.
  2. Change the pname so that it is normalized.
  3. Change "cd" in prePatch to sourceRoot.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Lucus16, evanjs and roelvandijk August 13, 2023 00:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 13, 2023
@tjni tjni merged commit 4107024 into NixOS:master Aug 17, 2023
@tjni tjni deleted the openrazer-daemon branch August 17, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant