Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.ninja: export BIN_DIR constant #248826

Merged
merged 1 commit into from
Aug 14, 2023
Merged

python3.pkgs.ninja: export BIN_DIR constant #248826

merged 1 commit into from
Aug 14, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

This is used by ale-py here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni changed the base branch from staging to staging-next August 14, 2023 17:01
@tjni tjni marked this pull request as ready for review August 14, 2023 17:01
@tjni
Copy link
Contributor Author

tjni commented Aug 14, 2023

I did not catch this early enough, and #246963 broke staging-next in #248496. I verify locally that this change fixes the issue there with rapidfuzz. If CI passes, I'm going to merge this to fix that issue.

@vcunat vcunat mentioned this pull request Aug 14, 2023
2 tasks
@vcunat vcunat merged commit f11e74c into NixOS:staging-next Aug 14, 2023
@tjni tjni deleted the ninja branch August 14, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants