Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.insteon-frontend-home-assistant: unpin setuptools dependency #248859

Merged
merged 1 commit into from
Aug 19, 2023
Merged

python3.pkgs.insteon-frontend-home-assistant: unpin setuptools dependency #248859

merged 1 commit into from
Aug 19, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

This will now pass build tool's stronger dependency validation in preparation for switching to it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Aug 13, 2023

Result of nixpkgs-review pr 248859 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.insteon
  • python310Packages.insteon-frontend-home-assistant
  • python310Packages.insteon-frontend-home-assistant.dist
  • python311Packages.insteon-frontend-home-assistant
  • python311Packages.insteon-frontend-home-assistant.dist

@natsukium
Copy link
Member

@ofborg build python310Packages.insteon-frontend-home-assistant

@natsukium natsukium merged commit e5e99ac into NixOS:master Aug 19, 2023
@tjni tjni deleted the insteon-frontend-home-assistant branch August 19, 2023 00:49
nativeBuildInputs = [
setuptools
wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add wheel given that the patch removes it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. The patch removes declaring it as a build dependency in pyproject.toml but it doesn't mean that wheel isn't a dependency. PEP 517 describes that a build backend like setuptools can declare additional build dependencies via the get_requires_for_build_wheel and get_requires_for_build_sdist methods, which setuptools does. It's best practice not to include wheel as a dependency in pyproject.toml because then it will be downloaded even in an sdist build (though that doesn't apply to us in nixpkgs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants