python3.pkgs.tiler: unpin setuptools-scm dependency #248949
Conversation
| nativeBuildInputs = [ | ||
| setuptools | ||
| setuptools-scm | ||
| wheel |
There was a problem hiding this comment.
I don't know much about how build works, but do we need wheel for nativeBuildInputs? Your patch seems to remove it from pyproject.toml.
There was a problem hiding this comment.
Yes, it looks confusing, and I can explain. We use build to build a wheel (instead of an sdist), and setuptools always needs wheel in order to do this. PEP 517 provides a way for a build backend like setuptools to specify any additional dependencies it needs in order to build a wheel, which setuptools does here, so it does not need to be listed in pyproject.toml. (In fact, when it is listed in pyproject.toml, it is always included, even for an sdist build, which is unnecessary in this case.)
A normal PEP 517 build would create an isolated virtual environment and download wheel automatically, but in nixpkgs we have to explicitly specify it.
There was a problem hiding this comment.
Thanks for the clarification!
I'll take another look at your amazing work in light of this.
|
@ofborg build python310Packages.tiler |
Description of changes
Pull in a patch that unpins the setuptools-scm dependency, which will be needed when we switch to
build.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)