Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.dask: remove references to versioneer #249486

Merged
merged 1 commit into from
Aug 19, 2023
Merged

python3.pkgs.dask: remove references to versioneer #249486

merged 1 commit into from
Aug 19, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 16, 2023

Description of changes

The current version of versioneer in nixpkgs is 0.29, while dask pins its versioneer dependency to 0.29 0.28. I submitted a PR upstream to unpin it, but upon closer inspection it looks like we patch out versioneer in the code. This change removes references to it from a few other places and tries to remove the dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 16, 2023

The current version of versioneer in nixpkgs is 0.29, while dask pins its versioneer dependency to 0.29.

one of these is 0.28

@tjni
Copy link
Contributor Author

tjni commented Aug 16, 2023

Oops, good catch. Fixed.

@natsukium
Copy link
Member

@ofborg build python310Packages.dask

@natsukium natsukium merged commit 5a88a87 into NixOS:master Aug 19, 2023
@tjni tjni deleted the dask branch August 19, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants