Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.scikit-build-core: add missing test dependencies #249646

Merged
merged 1 commit into from
Aug 17, 2023
Merged

python3.pkgs.scikit-build-core: add missing test dependencies #249646

merged 1 commit into from
Aug 17, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 16, 2023

Description of changes

  1. There are a couple of test dependencies that need to be specified explicitly.
  2. In a previous commit, I accidentally thought that scikit-build-core needed the actual cmake program, when what it actually needs is the cmake Python package when running its tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium merged commit 95c5102 into NixOS:staging Aug 17, 2023
@tjni tjni deleted the scikit-build-core branch August 17, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants