Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.scramp: remove versioningit reference #249768

Closed
wants to merge 1 commit into from
Closed

python3.pkgs.scramp: remove versioningit reference #249768

wants to merge 1 commit into from

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 17, 2023

Description of changes

And add wheel to the nativeBuildInputs. This will eventually be checked by build when we switch to it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni changed the base branch from master to staging August 17, 2023 17:05
@tjni tjni marked this pull request as ready for review August 17, 2023 17:05
@natsukium
Copy link
Member

@ofborg build python310Packages.scramp

@tjni
Copy link
Contributor Author

tjni commented Aug 20, 2023

Merged in #248866.

@tjni tjni closed this Aug 20, 2023
@tjni tjni deleted the scramp branch August 20, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants