Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.libtmux: remove setuptools build dependency #249775

Merged
merged 1 commit into from
Aug 18, 2023
Merged

python3.pkgs.libtmux: remove setuptools build dependency #249775

merged 1 commit into from
Aug 18, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 17, 2023

Description of changes

This was added by upstream awhile back to support pip install -e ., which we don't need. It is also not necessary anymore when using pip > 21.3. So let's pull in a patch to get rid of it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member

@ofborg build python310Packages.libtmux

@natsukium natsukium merged commit 20a431f into NixOS:master Aug 18, 2023
@tjni tjni deleted the libtmux branch August 18, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants