Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli2: enable building without pip in the environment #249798

Merged
merged 1 commit into from
Aug 18, 2023
Merged

awscli2: enable building without pip in the environment #249798

merged 1 commit into from
Aug 18, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 17, 2023

Description of changes

This package has a special check that runs prior to building that checks for pip in the environment. We do not need pip in the environment (it's only there right now by coincidence and will be removed soon) as we provide all the dependencies needed through PYTHONPATH. So we need to relax this check from upstream.

I did this in postPatch because it's not clear to me that this is something that should be upstreamed. (It looks like it has been added specifically to address some concern in their environment.)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member

natsukium commented Aug 18, 2023

@ofborg build python310Packages.awscli2

@natsukium natsukium merged commit 60e9a03 into NixOS:master Aug 18, 2023
@tjni tjni deleted the awscli2 branch August 18, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants