Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatcam: do not pin setuptools in shapely #249849

Merged
merged 1 commit into from
Aug 24, 2023
Merged

flatcam: do not pin setuptools in shapely #249849

merged 1 commit into from
Aug 24, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 18, 2023

Description of changes

In the 1.8.x branch of shapely, setuptools was pinned to less than 64 because of a bug the maintainers were seeing related to Windows tests (shapely/shapely#1481). We don't have that problem, and in fact we are on a newer version of setuptools. Once we migrate to build, this version constraint will start failing the build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member

I suggest that we update the version of shapely as per this comment. #249847 (comment)
However, a major update is required and needs to be checked.

@natsukium
Copy link
Member

I found this while drowning in the sea of PR.
#248004

@tjni tjni marked this pull request as draft August 24, 2023 00:46
@tjni tjni changed the base branch from master to staging-next August 24, 2023 00:46
@tjni tjni marked this pull request as ready for review August 24, 2023 00:46
@tjni tjni mentioned this pull request Aug 24, 2023
12 tasks
@tjni
Copy link
Contributor Author

tjni commented Aug 24, 2023

Merging this first to unbreak the build. Will follow up on updating it.

@tjni tjni merged commit 093f591 into NixOS:staging-next Aug 24, 2023
@tjni tjni deleted the flatcam branch August 24, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants