Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: remove pip from anki-build-python #250059

Merged
merged 1 commit into from
Aug 19, 2023
Merged

anki: remove pip from anki-build-python #250059

merged 1 commit into from
Aug 19, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 18, 2023

Description of changes

I am trying to fix this failure on the python-updates branch, which is testing some changes that includes updating pip:

error: collision between `/nix/store/n3kxpnlhnbcm46xnkf6zka704darazzz-python3-3.10.12-env/bin/pip3.10' and `/nix/store/n9jd7i76x2vcgp5l5imaa1141mi05s4p-python3.10-pip-23.2.1/bin/pip3.10'

I am not sure why it doesn't happen currently. I'm not able to test the behavior of the application, because I'm on macOS, but I have been able to verify it still builds on aarch64-linux. If anyone is able to better test this, please do!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it still builds and runs on x86 linux just fine for me.

Thanks!

@tjni tjni merged commit 50a4d63 into NixOS:master Aug 19, 2023
@tjni tjni deleted the anki branch August 19, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants