Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faraday-agent-dispatcher: 2.4.0 -> 2.6.2 #250110

Merged
merged 2 commits into from
Aug 19, 2023
Merged

faraday-agent-dispatcher: 2.4.0 -> 2.6.2 #250110

merged 2 commits into from
Aug 19, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

I am not sure why, but the current version is failing to build with test failures after Python bootstrapping changes I've made:

FAILED tests/unittests/test_config_wizard.py::test_new_config[no .ini-Basic Repo Executors input] - AssertionError: assert set() == {'ex1'}
FAILED tests/unittests/test_config_wizard.py::test_new_config[0.1.ini-Basic Repo Executors input] - AssertionError: assert {'unnamed_executor'} == {'ex1', 'unnamed_executor'}
FAILED tests/unittests/test_config_wizard.py::test_new_config[1.0.ini-Basic Repo Executors input] - AssertionError: assert {'test', 'test2'} == {'ex1', 'test', 'test2'}
FAILED tests/unittests/test_config_wizard.py::test_new_config[1.2.ini-Basic Repo Executors input] - AssertionError: assert {'test', 'test2', 'test3'} == {'ex1', 'test...st2', ...
FAILED tests/unittests/test_config_wizard.py::test_new_config[1.5.ini-Basic Repo Executors input] - AssertionError: assert {'test', 'test2', 'test3'} == {'ex1', 'test...st2', ...

However, everything starts to pass once we update to the latest version, so let's try that! The new version also revealed that pytenable's dependencies were not being properly propagated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Aug 19, 2023

Result of nixpkgs-review pr 250110 run on x86_64-linux 1

6 packages built:
  • faraday-agent-dispatcher
  • faraday-agent-dispatcher.dist
  • python310Packages.pytenable
  • python310Packages.pytenable.dist
  • python311Packages.pytenable
  • python311Packages.pytenable.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 54563b9 into NixOS:master Aug 19, 2023
@tjni tjni deleted the faraday-agent-dispatcher branch August 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants