Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.python-rtmidi: 1.5.4 -> 1.5.5 #250117

Merged
merged 1 commit into from
Aug 21, 2023
Merged

python3.pkgs.python-rtmidi: 1.5.4 -> 1.5.5 #250117

merged 1 commit into from
Aug 21, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

https://github.com/SpotlightKid/python-rtmidi/releases/tag/1.5.5

I was adding some build dependencies that were needed in this package. The update picks up some fixes for Cython 3 as well after adding that as a build dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 19, 2023

@ofborg build python310Packages.python-rtmidi python311Packages.python-rtmidi

@natsukium
Copy link
Member

It is already broken on darwin.
https://hydra.nixos.org/build/231633375

@natsukium
Copy link
Member

Result of nixpkgs-review pr 250117 run on x86_64-linux 1

17 packages built:
  • cantoolz
  • cantoolz.dist
  • ledfx
  • ledfx.dist
  • open-stage-control
  • pianotrans
  • pianotrans.dist
  • python310Packages.mido
  • python310Packages.mido.dist
  • python310Packages.piano-transcription-inference
  • python310Packages.piano-transcription-inference.dist
  • python310Packages.python-rtmidi
  • python310Packages.python-rtmidi.dist
  • python311Packages.mido
  • python311Packages.mido.dist
  • python311Packages.python-rtmidi
  • python311Packages.python-rtmidi.dist

@natsukium natsukium merged commit a7d8793 into NixOS:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants