home-assistant: unpin and fix build dependencies #250124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'm on mobile currently, so I'll take a more thorough look tonight. |
mweinelt
reviewed
Aug 19, 2023
Comment on lines
+374
to
+375
| sed -i 's/setuptools[~=]/setuptools>/' pyproject.toml | ||
| sed -i 's/wheel[~=]/wheel>/' pyproject.toml |
There was a problem hiding this comment.
Have you tried adding it to relaxedConstraints above?
There was a problem hiding this comment.
That breaks as it expects one dependency per line.
mweinelt
reviewed
Aug 20, 2023
Comment on lines
+37
to
+44
| patches = [ | ||
| # https://github.com/home-assistant/intents-package/pull/1 | ||
| (fetchpatch { | ||
| name = "unpin-setuptools-dependency.patch"; | ||
| url = "https://github.com/home-assistant/intents-package/commit/fc03c1ec1001ba3b812f2eea670d1c447cf2acee.patch"; | ||
| hash = "sha256-kTu1+IwDrcdqelyK/vfhxw8MQBis5I1jag7YTytKQhs="; | ||
| }) | ||
| ]; |
There was a problem hiding this comment.
Good luck getting anything merged after having mentioned you require this for nixpkgs.
|
Might as well go in as is. I'll have to clean up the whole dependency versioning story anyway. |
|
Merged in #248866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These changes will be needed once we switch over to building Python packages with
build.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)