Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.aiomysql: fix build dependency constraints #250206

Merged
merged 1 commit into from
Aug 19, 2023
Merged

python3.pkgs.aiomysql: fix build dependency constraints #250206

merged 1 commit into from
Aug 19, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

  1. Pull patch that updates setuptools-scm and removes setuptools-scm-git-archive.
  2. Add wheel as an explicit build dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor

Shouldn't we wait until the PR you linked in the diff lands in a release?

@tjni
Copy link
Contributor Author

tjni commented Aug 19, 2023

It's unclear when a release will be made, and I need something like that for the work in #247287, because building a package with build validates build dependency constraints. At the moment, the failing constraint is that setuptools-scm in nixpkgs is too recent.

@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 250206 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • python310Packages.orm
  • python310Packages.orm.dist
  • python310Packages.ormar
  • python310Packages.ormar.dist
  • python311Packages.orm
  • python311Packages.orm.dist
  • python311Packages.ormar
  • python311Packages.ormar.dist
4 packages built:
  • python310Packages.aiomysql
  • python310Packages.aiomysql.dist
  • python311Packages.aiomysql
  • python311Packages.aiomysql.dist

@tjni tjni merged commit 81e317a into NixOS:master Aug 19, 2023
@tjni tjni deleted the aiomysql branch August 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants