Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.ale-py: add missing ninja dependency #250211

Merged
merged 1 commit into from
Aug 20, 2023
Merged

python3.pkgs.ale-py: add missing ninja dependency #250211

merged 1 commit into from
Aug 20, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

This is detected when building this package using build, which we are switching Python packages to using.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 250211 run on x86_64-linux 1

4 packages built:
  • python310Packages.ale-py
  • python310Packages.ale-py.dist
  • python311Packages.ale-py
  • python311Packages.ale-py.dist

Copy link
Contributor

@BillHuang2001 BillHuang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked, they do have ninja listed as a requirement.
lgtm

@tjni tjni merged commit 0b07d49 into NixOS:master Aug 20, 2023
@tjni tjni deleted the ale-py branch August 20, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants