Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.linear_operator: use setuptools-scm to get version #250240

Merged
merged 1 commit into from
Aug 20, 2023
Merged

python3.pkgs.linear_operator: use setuptools-scm to get version #250240

merged 1 commit into from
Aug 20, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

Trying to build this package using build flagged that it uses setuptools-scm for versioning, so we can refactor the derivation to leverage that and remove some patching we were doing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Aug 19, 2023

@GrahamcOfBorg build python3.pkgs.ax

@veprbl veprbl merged commit 5ff791b into NixOS:master Aug 20, 2023
@tjni tjni deleted the linear_operator branch August 20, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants