Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.imageio-ffmpeg: patch out pip requirement #250458

Merged
merged 1 commit into from
Aug 22, 2023
Merged

python3.pkgs.imageio-ffmpeg: patch out pip requirement #250458

merged 1 commit into from
Aug 22, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 21, 2023

Description of changes

This package includes pip>19 in its setup_requires. Upstream does this to help users who install with pip, but it is not needed to build the package, so let's patch it out.

Closes #249637. (I mistakenly thought it required wheel but it just requires pip.)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 21, 2023

@ofborg build python310Packages.imageio-ffmpeg python311Packages.imageio-ffmpeg

@ofborg ofborg bot requested a review from pmiddend August 21, 2023 02:43
@tjni tjni merged commit bb604b3 into NixOS:master Aug 22, 2023
@tjni tjni deleted the imageio-ffmpeg branch August 22, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imageio-ffmpeg: declares build-time dependency on wheel. audit why
1 participant