Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeScopeWithSplicing: fix makeScopeWithSplicing' call #250575

Merged
merged 1 commit into from
Aug 21, 2023
Merged

makeScopeWithSplicing: fix makeScopeWithSplicing' call #250575

merged 1 commit into from
Aug 21, 2023
+4 −4

Conversation

Artturin
Copy link
Member

makeScopeWithSplicing: fix comment

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Aug 21, 2023
Merged
12 tasks
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Aug 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 21, 2023
@Artturin Artturin merged commit 25d583b into NixOS:master Aug 21, 2023
@Artturin Artturin deleted the fixcall1 branch August 21, 2023 18:12
lopsided98
lopsided98 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this fixes evaluating my NixOS config, thanks!

@AndersonTorres
Copy link
Member

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@lopsided98 lopsided98 lopsided98 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Artturin @AndersonTorres @lopsided98 @infinisil