Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.cmsis-pack-manager: fix install using pypa installer #250649

Merged
merged 1 commit into from
Aug 23, 2023
Merged

python3.pkgs.cmsis-pack-manager: fix install using pypa installer #250649

merged 1 commit into from
Aug 23, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

After #248866 was committed, we now use installer instead of pip to install wheels. As reported in pyocd/cmsis-pack-manager#207, we cannot install this from the PyPI artifact: for some reason, the wheel that is created has duplicated files in the archive, and installer does not like it.

This isn't a problem when installing from the GitHub sources.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member

@ofborg build python310Packages.cmsis-pack-manager

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit b5f1a01 into NixOS:master Aug 23, 2023
@tjni tjni deleted the cmsis-pack-manager branch August 23, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants