Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.fiona: relax build dependencies #250700

Merged
merged 1 commit into from
Aug 23, 2023
Merged

python3.pkgs.fiona: relax build dependencies #250700

merged 1 commit into from
Aug 23, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

Since #248866, this package no longer builds because it enforces stronger build-time dependency validation. These issues have been fixed upstream but are combined with other changes and have not yet been released, so I chose to patch the dependency constraints in postPatch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.fiona python311Packages.fiona

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me.

@tjni tjni merged commit 50eeacc into NixOS:master Aug 23, 2023
@tjni tjni deleted the fiona branch August 23, 2023 21:55
@imincik
Copy link
Contributor

imincik commented Aug 24, 2023

Thank you for the fix @tjni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants