Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libavif: disable gdk-pixbuf thumbnailer when cross-compiling #250813

Merged
1 commit merged into from
Aug 23, 2023

Conversation

lopsided98
Copy link
Contributor

Description of changes

gdk-pixbuf doesn't support thumbnailers when cross-compiling, causing libavif to fail to cross-compile because it tries to wrap ${gdk-pixbuf}/bin/gdk-pixbuf-thumbnailer, which doesn't exist.

This doesn't cause any rebuilds when not cross-compiling.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • armv6l-linux (cross)
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @amjoseph-nixpkgs @mkg20001 @ncfavier

gdk-pixbuf doesn't support thumbnailers when cross-compiling, causing
libavif to fail to cross-compile because it tries to wrap
${gdk-pixbuf}/bin/gdk-pixbuf-thumbnailer, which doesn't exist.
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 22, 2023
@ghost ghost merged commit c84563d into NixOS:master Aug 23, 2023
@lopsided98 lopsided98 deleted the libavif-cross-thumbnailer branch August 23, 2023 05:18
@lopsided98
Copy link
Contributor Author

For reference, here is the discussion of why the thumbnailer is disabled when cross-compiling: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/64

@ghost
Copy link

ghost commented Aug 23, 2023

It would be super cute if, when cross-compiling, we dropped in a shell script where the thumbnailer ought to be, which echoed that link and then did an exit 1.

But maybe that's too cute.

@ghost ghost mentioned this pull request Aug 23, 2023
12 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants