Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.pulumi: add missing pip test dependency #250817

Merged
merged 1 commit into from
Aug 23, 2023
Merged

python3.pkgs.pulumi: add missing pip test dependency #250817

merged 1 commit into from
Aug 23, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

The preCheck phase requires pip, but it's no longer available in the environment after #248866.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.pulumi python311Packages.pulumi

@teto
Copy link
Member

teto commented Aug 22, 2023

Result of nixpkgs-review pr 250817 run on x86_64-linux 1

16 packages built:
  • python310Packages.pulumi
  • python310Packages.pulumi-aws
  • python310Packages.pulumi-aws-native
  • python310Packages.pulumi-aws-native.dist
  • python310Packages.pulumi-aws.dist
  • python310Packages.pulumi-azure-native
  • python310Packages.pulumi-azure-native.dist
  • python310Packages.pulumi-command
  • python310Packages.pulumi-command.dist
  • python310Packages.pulumi-random
  • python310Packages.pulumi-random.dist
  • python310Packages.pulumi.dist
  • python311Packages.pulumi
  • python311Packages.pulumi-aws
  • python311Packages.pulumi-aws.dist
  • python311Packages.pulumi.dist

@natsukium natsukium merged commit 96ba70e into NixOS:master Aug 23, 2023
@tjni tjni deleted the pulumi branch August 23, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants