Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.python-lsp-server: relax jedi dependency constraint #250824

Merged
merged 1 commit into from
Aug 24, 2023
Merged

python3.pkgs.python-lsp-server: relax jedi dependency constraint #250824

merged 1 commit into from
Aug 24, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

This will be needed so that builds continue working on staging-next after 39fc433. In particular, pyls-flake8 and python-lsp-black seem to require relaxing this so that their tests pass (for some reason).

We could also add jedi to pythonRelaxDeps but I guess my personal preference is to pull in patches when they exist on upstream. When upstream releases a version with the patch, it is easier to trace and clean up.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.python-lsp-server python311Packages.python-lsp-server python310Packages.pyls-flake8 python311Packages.pyls-flake8 python310Packages.python-lsp-black python311Packages. python-lsp-black

@tjni tjni changed the base branch from master to staging-next August 24, 2023 00:11
@tjni tjni marked this pull request as ready for review August 24, 2023 00:11
@tjni
Copy link
Contributor Author

tjni commented Aug 24, 2023

Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier.

@tjni tjni merged commit 6c68146 into NixOS:staging-next Aug 24, 2023
@tjni tjni deleted the python-lsp-server branch August 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant