Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2Packages.ninja: alias it to ninja build tool #251548

Merged
merged 1 commit into from
Aug 26, 2023
Merged

python2Packages.ninja: alias it to ninja build tool #251548

merged 1 commit into from
Aug 26, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 26, 2023

Description of changes

This undoes #246963 for Python 2.

An easy way to fix this is to switch the stub from using flit-core to using setuptools, but I want to buy myself some time to try out some potential alternatives.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni requested a review from FRidh August 26, 2023 08:17
@FRidh FRidh merged commit 8489284 into NixOS:master Aug 26, 2023
@tjni tjni deleted the python2-ninja-regression branch August 26, 2023 15:44
bryango added a commit to bryango/nixpkgs-config that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants