Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.ansible-pylibssh: patch out setuptools_scm_git_archive #251679

Merged
merged 1 commit into from
Aug 26, 2023
Merged

python310Packages.ansible-pylibssh: patch out setuptools_scm_git_archive #251679

merged 1 commit into from
Aug 26, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 26, 2023

Description of changes

I missed in #247367 that setuptools_scm_git_archive is still requested in pyproject.toml. This only fails on staging-next because of Python bootstrapping changes there.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 26, 2023

I'm going to merge this for now to fix these failing builds on staging-next, but I am happy to address any feedback you send my way on how this should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant