Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.scikit-image: relax numpy dependency constraint #251708

Merged
merged 1 commit into from
Aug 27, 2023
Merged

python310Packages.scikit-image: relax numpy dependency constraint #251708

merged 1 commit into from
Aug 27, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 27, 2023

Description of changes

Fix the broken build on #250778.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Aug 27, 2023

I'm going to merge this to minimize breakages because I'm quite confident that it fixes the current issue on staging-next (I have been fixing a lot of these issues in the past week since I introduced the change that leads to it). @yl3dy and others: if you review and leave any feedback, I will make sure to follow up and address it.

@tjni tjni merged commit b405a28 into NixOS:staging-next Aug 27, 2023
@tjni tjni deleted the scikit-image branch August 27, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant