-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-snmp-exporter: 0.22.0 -> 0.25.0 #251882
prometheus-snmp-exporter: 0.22.0 -> 0.25.0 #251882
Conversation
e3fe7d2
to
99d56bc
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/prometheus/snmp_exporter/releases. meta.description for prometheus-snmp-exporter is: SNMP Exporter for Prometheus meta.homepage for prometheus-snmp-exporter is: https://github.com/prometheus/snmp_exporter Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @oida @WilliButz @Frostman for testing. |
99d56bc
to
7aa6a0e
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/snmp-exporter/versions. meta.description for prometheus-snmp-exporter is: SNMP Exporter for Prometheus meta.homepage for prometheus-snmp-exporter is: https://github.com/prometheus/snmp_exporter Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @oida @WilliButz @Frostman for testing. |
@ofborg test prometheus-exporters.snmp |
@WilliButz Looking at the changelogs I'm not sure to see the security issue. Is this for this prometheus/snmp_exporter#968 ? There are breaking changes in the 0.23.0 version, we will not be able to backport it to 23.11. |
Now I'm a bit confused here as well, thank you for asking @LeSuisse. Looking at the dependencies of the exporter version currently in nixpkgs I see exporter-toolkit at version 0.10.0 and I don't quite follow how it's supposed to be affected by https://nvd.nist.gov/vuln/detail/CVE-2022-46146. Although https://security.gentoo.org/glsa/202401-15 shows that versions <0.24.1 are vulnerable, which I guess is based on this comment: https://bugs.gentoo.org/883649#c1 @mweinelt do you have some additional insights? |
My bad, my info did indeed come from the Gentoo advisory and I did not check it further. |
@mweinelt ah thank you for resolving the confusion, I also didn't check if it was indeed affected. I only checked that the dependency for 0.25.0 isn't and repurposed this PR. In this case I'd just make this a regular update, drop the security label and add a small note to the 24.05 release notes about the breaking change. Also, I'll remove myself as maintainer here, as I'm not currently actively using the exporter. |
65e72b0
to
9128a88
Compare
The Gentoo advisory seems to be incomplete, I think it refers to the commit you linked but it is available since 0.23.0 in this exporter 😅 . For 23.11 we can probably backport only the lib update. |
This is introduced and enabled by default because the config syntax for the exporter changed with release 0.23.0. This should make the breaking config change obvious before services are deployed with an incompatible old config. The check is based on the check present in the blackbox-exporter module.
9128a88
to
4bd2f9c
Compare
rebased on master to resolve the conflicting release notes.
@LeSuisse I don't follow, which part would you want to backport? |
I was thinking of backporting prometheus/snmp_exporter@7dea13b |
Oh, I think that is part of the misunderstanding. Version 0.22.0 is currently on stable, that already depends on a more recent version than the one referenced in that commit. See https://github.com/prometheus/snmp_exporter/blob/v0.22.0/go.sum#L45-L46 |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/prometheus/snmp_exporter/releases.
meta.description for prometheus-snmp-exporter is: SNMP Exporter for Prometheus
meta.homepage for prometheus-snmp-exporter is: https://github.com/prometheus/snmp_exporter
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests
did not passRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 11 package built:
Maintainer pings
cc @oida @WilliButz @Frostman for testing.