Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.pdf2docx: add pip as a build dependency #252361

Merged
merged 1 commit into from
Aug 30, 2023
Merged

python310Packages.pdf2docx: add pip as a build dependency #252361

merged 1 commit into from
Aug 30, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 30, 2023

Description of changes

This started failing after #248866. Looks like its setup.py imports pip, and pip was removed from the ambient environment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor

Thank you !

@happysalada happysalada merged commit 8dd35e1 into NixOS:master Aug 30, 2023
@tjni tjni deleted the pdf2docx branch August 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants