Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_7zz: fix build with clang 13+ #253740

Merged
merged 1 commit into from
Sep 7, 2023
Merged

_7zz: fix build with clang 13+ #253740

merged 1 commit into from
Sep 7, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

7zz uses -Weverything and -Werror, which results in normally disabled warnings breaking the build with newer versions of clang.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

7zz uses `-Weverything` and `-Werror`, which results in normally
disabled warnings breaking the build with newer versions of clang.
@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 253740 run on aarch64-darwin 1

3 packages built:
  • _7zz
  • jprofiler
  • unnaturalscrollwheels

@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 253740 run on x86_64-darwin 1

9 packages built:
  • _7zz
  • febio
  • jprofiler
  • mkl
  • python310Packages.mkl-service
  • python310Packages.mkl-service.dist
  • python311Packages.mkl-service
  • python311Packages.mkl-service.dist
  • unnaturalscrollwheels

@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 253740 run on aarch64-linux 1

@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 253740 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2023
@Artturin Artturin merged commit 8988d58 into NixOS:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants