Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testers.testMetaPkgConfig: fix warning #256129

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 19, 2023

Description of changes

follow-up to feabc3d / #247920

before:

$ nix-instantiate -A curl.passthru.tests
/nix/store/69hkq0f92kvhmaa2snhs8sngxq848ypj-coeurl-0.3.0.drv
/nix/store/6vrl59bswmggpgvvk2wj99g6jxh123lk-curlpp-0.8.1.drv
/nix/store/fvbvg8yj2m0wvjdbijsfg395d2rk2hfn-source-salted-1dgvmnzzhxfq.drv
/nix/store/balx26mkxhjri9rdz22yycnhvjni6c2v-curl-1.3.8.drv
/nix/store/lj9q8bv3py8mnzv6139735lfvl781370-vm-test-run-nginx-http3.drv
/nix/store/pdl6ybssy397r488r2pky3y2kbzhr8yn-ocaml4.14.1-curly-0.2.0.drv
/nix/store/ljxh8wyyaw9zn807dqwqsb5cl8zcchnr-php-curl-8.2.10.drv
trace: warning: testers.hasPkgConfigModule has been deprecated in favor of testers.hasPkgConfigModules. It accepts a list of strings via the moduleNames argument instead of a single moduleName.
/nix/store/0svvl3vnfa844xnk0v4yfs5mgklcm9sw-check-meta-pkg-config-modules-for-curl-8.2.1.drv
/nix/store/w10x055i8jcw7s0n13dp3msj6rzmx0n5-python3.10-pycurl-7.45.1.drv
/nix/store/h5p2zwbj8h51clfyj5bbydrw6cy1d9ih-curl-8.2.1.drv!bin

after:

$ nix-instantiate -A curl.passthru.tests
/nix/store/69hkq0f92kvhmaa2snhs8sngxq848ypj-coeurl-0.3.0.drv
/nix/store/6vrl59bswmggpgvvk2wj99g6jxh123lk-curlpp-0.8.1.drv
/nix/store/fvbvg8yj2m0wvjdbijsfg395d2rk2hfn-source-salted-1dgvmnzzhxfq.drv
/nix/store/balx26mkxhjri9rdz22yycnhvjni6c2v-curl-1.3.8.drv
/nix/store/lj9q8bv3py8mnzv6139735lfvl781370-vm-test-run-nginx-http3.drv
/nix/store/pdl6ybssy397r488r2pky3y2kbzhr8yn-ocaml4.14.1-curly-0.2.0.drv
/nix/store/ljxh8wyyaw9zn807dqwqsb5cl8zcchnr-php-curl-8.2.10.drv
/nix/store/0svvl3vnfa844xnk0v4yfs5mgklcm9sw-check-meta-pkg-config-modules-for-curl-8.2.1.drv
/nix/store/w10x055i8jcw7s0n13dp3msj6rzmx0n5-python3.10-pycurl-7.45.1.drv
/nix/store/h5p2zwbj8h51clfyj5bbydrw6cy1d9ih-curl-8.2.1.drv!bin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 19, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 19, 2023
@roberth roberth merged commit 18c2786 into NixOS:master Sep 20, 2023
@ajs124 ajs124 deleted the fix/testmetapkgconf-warning branch September 20, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants