-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spacy: added Explosion AI spaCy, thinc and related tools #25791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good overall
- Remove meta.platforms
- Preferably use fetchPypi
- Do not commit whitespace changes in
python-packages.nix
meta = with stdenv.lib; { | ||
description = "Cython memory pool for RAII-style memory management"; | ||
homepage = https://github.com/explosion/cymem; | ||
platforms = platforms.unix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't set platforms in Python packages. The function already takes care of that.
|
||
buildInputs = [ | ||
pytest | ||
nose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs pytest and nose, but uses unittest as runner? That's odd.
name = "ftfy-${version}"; | ||
version = "4.4.2"; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi
}; | ||
|
||
propagatedBuildInputs = [ | ||
cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a runtime dependency, or is it?
A requirements.txt file doesn't say much, because its not used when building a package with setuptools, unless its explicitly read and added to e.g. If a package is only used during build and install time, then it should be added to |
@FRidh, thank you for teaching me to look into the code closer! I have changed ftfy to make Travis CI builds work for GNU/Linux and OS X, opening an issue about it in @LuminosoInsight's repo here. I have also changed murmurhash build inputs as requested. |
@FRidh, I moved recipes to satisfy the 'package/default.nix' format, as well as replaced OS X Travis seems to time out, could you please tell me how I can decrease the build time? My first idea was to set |
@sdll you can ignore Travis. While it is sometimes useful, we cannot really rely on it. |
@FRidh, is there anything else I need to change? Is the tag "needs: clean-up" still relevant? |
@FRidh, I have updated the recipe for ftfy, changing its version to 4.4.3, the testing issue was fixed (see rspeer/python-ftfy#75) I have also added pip as a dependency for spaCy, because its |
Travis CI on OS X seems to fail again due to the same error as in #25804:
Similarly, do you think we should try to fix it by specifying GCC_INSTALL_HOME? Is there a deeper problem with how clang c++ headers are treated in the OS X build of Nix? Shall I file an issue? |
@knedlsepp is this related to #27649? (I'm just diving through old PR's) |
@FRidh: Seems highly likely. I'll try to rework my PR asap, so we can merge. |
This needs a minor rebase. I successfully built the 2.7 version of spacy but the 3.6 hang during building. |
I've pushed this to master. |
Great work! Any idea how to install the data using Nix? (E.g. |
Motivation for this change
Making NLP analysis easier with Nix.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)