Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libiscsi: fix build on clang 16 #259285

Merged
merged 1 commit into from
Oct 6, 2023
Merged

libiscsi: fix build on clang 16 #259285

merged 1 commit into from
Oct 6, 2023

Conversation

viraptor
Copy link
Contributor

@viraptor viraptor commented Oct 6, 2023

Description of changes

Build fails on a strict prototype error. #234710

Things done

Fix the missing strict prototype

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from misuzu October 6, 2023 01:08
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 6, 2023
@viraptor viraptor changed the base branch from master to staging October 6, 2023 06:19
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 6, 2023
@ofborg ofborg bot requested a review from misuzu October 6, 2023 07:05
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 6, 2023
@ofborg ofborg bot requested a review from misuzu October 6, 2023 08:38
@viraptor viraptor merged commit f33fcec into NixOS:staging Oct 6, 2023
@viraptor viraptor deleted the libiscsi-clang branch October 6, 2023 20:21
@reckenrode reckenrode mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu Awaiting requested review from misuzu

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viraptor @misuzu @delroth