Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: 24.4 -> 25.3 #264902

Merged
merged 1 commit into from
May 22, 2024
Merged

protobuf: 24.4 -> 25.3 #264902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/top-level/all-packages.nix
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the README says that

  • the cpp (.../pyext) backend is "legacy" and advises to use the μpb backend,
  • mentions that

    While upb offers a C API, the C API & ABI are not stable. For this reason, upb is not generally offered as a C library for direct consumption, and there are no releases. https://github.com/protocolbuffers/protobuf/tree/main/upb

Did we ever have any ABI compatibility guarantees with cpp? I'm wondering if we could do any tricks for tensorflow like build it with the older protobuf but link the newer one, and also maybe use nixpkgs-pytools to rename its references to the old protobuf python module? (only relevant until we update tf to 2.15?)

Original file line number Diff line number Diff line change
Expand Up @@ -23848,7 +23848,7 @@ with pkgs;

prospector = callPackage ../development/tools/prospector { };

protobuf = protobuf_24;
protobuf = protobuf_25;

inherit
({
Expand Down