Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: document new texlive.withPackages interface #265658

Merged
merged 1 commit into from
Nov 7, 2023
Merged

texlive: document new texlive.withPackages interface #265658

merged 1 commit into from
Nov 7, 2023

Conversation

xworld21
Copy link
Contributor

@xworld21 xworld21 commented Nov 5, 2023 •
edited
Loading

Description of changes

Document texlive.withPackages as new experimental interface.

Warning: do not merge before #265514, #265645!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: TeX Issues regarding texlive and TeX in general labels Nov 5, 2023
@xworld21 xworld21 force-pushed the texlive-withpackages-docs branch from b801285 to 7b34f38 Compare November 5, 2023 13:50
@xworld21 xworld21 mentioned this pull request Nov 5, 2023
Open
23 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2023
veprbl
veprbl approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2023
@veprbl veprbl merged commit aca44fe into NixOS:master Nov 7, 2023
@xworld21 xworld21 deleted the texlive-withpackages-docs branch November 8, 2023 17:14
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
Closed
13 tasks
nyabinary pushed a commit to nyabinary/nixpkgs that referenced this pull request Nov 14, 2023
@xworld21 @nyabinary
texlive: document new texlive.withPackages interface (NixOS#265658)
2fb3aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@apfelkuchen6 apfelkuchen6 Awaiting requested review from apfelkuchen6

Assignees
No one assigned
Labels
6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xworld21 @veprbl @delroth