Revert "rsync: fix regression with _FORTIFY_SOURCE=2" #265876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad38853.
|
FYI @ehmry. |
|
Commit messages for reverts should always explain the reason for the revert. You can do this when you merge, using the "Squash and merge" option. |
Gotcha, thank you for reminding me… ! |
Mic92
pushed a commit
to Mic92/nixpkgs
that referenced
this pull request
Nov 6, 2023
This reverts commit ad38853. This change while correct causes a mass-rebuild and needs to be resubmitted for staging.
Mic92
pushed a commit
that referenced
this pull request
Nov 7, 2023
This reverts commit ad38853. This change while correct causes a mass-rebuild and needs to be resubmitted for staging.
13 tasks
nyabinary
pushed a commit
to nyabinary/nixpkgs
that referenced
this pull request
Nov 14, 2023
This reverts commit ad38853. This change while correct causes a mass-rebuild and needs to be resubmitted for staging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #265846 — it should have gone to staging. We are cancelling evaluations, please resend the PR to staging.