-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
persepolis: ZHF: fix build and runtime errors on darwin #266050
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/should-i-fix-a-bug-within-nixpkgs-if-upstream-wont/35127/1 |
353b5cc
to
94e0701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I don't have darwin so i can't test nor review, but I do have some input reading through the diff.
pkgs/tools/networking/persepolis/0003-Search-PATH-for-aria2c-on-darwin.patch
Outdated
Show resolved
Hide resolved
pkgs/tools/networking/persepolis/0001-Allow-building-on-darwin.patch
Outdated
Show resolved
Hide resolved
94e0701
to
e89c0f4
Compare
Seems like #266670 got ahead of us. Could you rebase it on top of master an unmark it broken? |
Notifications will be broken until NixOS#105156 is resolved. ZHF: NixOS#265948
The video finder is still broken on youtube, but that's an upstream issue that we might not want to fix ourselves, see persepolisdm/persepolis#930
This fixes the upstream issue persepolisdm/persepolis#930
e89c0f4
to
bf62348
Compare
@ofborg build persepolis persepolis.passthru.tests |
Description of changes
This fixes the build and runtime errors on darwin as part of #265948.
Things done
youtube-dl
with maintained forkyt-dlp
to restore video finder functionality (this was broken on Linux and Darwin)nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)