-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.geoalchemy2: 0.14.1 -> 0.14.2 #266114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change the commit message and the PR title to python311Packages
from pythonPackages
?
pythonPackages
means the packages for Python2
.
Result of 2 packages failed to build:
2 packages built successfully:
The failure of flask-admin doesn't seem to be related to this update. |
I'm pretty sure changing this file updates geoalchemy2 for any python*Packages, so imho pythonPackages was the most neutral choice. Would you be fine with python*Packages ? Edit: Okay it doesn't doesn't support python 2, so maybe python3Packages? |
2f95a19
to
a479579
Compare
Of course, I know that it is not limited to python311. However, since ofborg cannot automatically build packages with python3Packages, which is the alias, I recommend using the default python311Packages. |
a479579
to
0f09d78
Compare
I see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Description of changes
This fixes the build of geoalchemy2 and also updates it to the latest minor version because why not.
ZHF: #265948
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)