Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.geoalchemy2: 0.14.1 -> 0.14.2 #266114

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Nov 7, 2023

Description of changes

This fixes the build of geoalchemy2 and also updates it to the latest minor version because why not.

ZHF: #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the commit message and the PR title to python311Packages from pythonPackages?
pythonPackages means the packages for Python2.

@natsukium
Copy link
Member

natsukium commented Nov 8, 2023

Result of nixpkgs-review pr 266114 at fd42e1df run on x86_64-linux 1

2 packages failed to build:
  • python310Packages.flask-admin
  • python311Packages.flask-admin
2 packages built successfully:
  • python310Packages.geoalchemy2
  • python311Packages.geoalchemy2

The failure of flask-admin doesn't seem to be related to this update.

@ghost ghost added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2023
@tu-maurice
Copy link
Contributor Author

tu-maurice commented Nov 8, 2023

Could you please change the commit message and the PR title to python311Packages from pythonPackages? pythonPackages means the packages for Python2.

I'm pretty sure changing this file updates geoalchemy2 for any python*Packages, so imho pythonPackages was the most neutral choice. Would you be fine with python*Packages ?

Edit: Okay it doesn't doesn't support python 2, so maybe python3Packages?

@tu-maurice tu-maurice force-pushed the unstable/python-fixes branch 2 times, most recently from 2f95a19 to a479579 Compare November 8, 2023 21:41
@natsukium
Copy link
Member

Of course, I know that it is not limited to python311. However, since ofborg cannot automatically build packages with python3Packages, which is the alias, I recommend using the default python311Packages.

@tu-maurice tu-maurice force-pushed the unstable/python-fixes branch from a479579 to 0f09d78 Compare November 9, 2023 10:06
@tu-maurice
Copy link
Contributor Author

I see.

@natsukium natsukium changed the title pythonPackages.geoalchemy2: 0.14.1 -> 0.14.2 python311Packages.geoalchemy2: 0.14.1 -> 0.14.2 Nov 10, 2023
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit b69c959 into NixOS:master Nov 10, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants